chore(tests): Add publish/unpublish to preview test. #13780
Conversation
b4handjr
requested review from
freshstrangemusic,
jaredlockhart and
yashikakhurana
as code owners
b4handjr
force-pushed
the
fix-8436
branch
2 times, most recently
from
880ea1b to
851516c
Compare
| r["id"]: r | ||
| for r in self.kinto_http_client.get_records( | ||
| bucket=settings.KINTO_BUCKET_MAIN, collection=self.collection | ||
| bucket=self.read_bucket, collection=self.collection |
There was a problem hiding this comment.
oh @b4handjr I think should make changes for local environment only so that we don't break the prod and stage, you can add a check and change the bucket accordingly
There was a problem hiding this comment.
Well I technically didn't break any tests... 🤐
There was a problem hiding this comment.
but test doesn't include our stage and prod, I am just worried about that
There was a problem hiding this comment.
Oh @yashikakhurana I don't think this changes which environment it goes to, it's just whether it's in the main or main-workspace collections in the local test kinto 🙏
| r["id"]: r | ||
| for r in self.kinto_http_client.get_records( | ||
| bucket=settings.KINTO_BUCKET_MAIN, collection=self.collection | ||
| bucket=self.read_bucket, collection=self.collection |
There was a problem hiding this comment.
Oh @yashikakhurana I don't think this changes which environment it goes to, it's just whether it's in the main or main-workspace collections in the local test kinto 🙏
Issues attributed to commits in this pull requestThis pull request was merged and Sentry observed the following issues:
|
Because
This commit
Fixes #8436